KubeVirt as a secondary manager of Container Providers #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkliczewski
approved these changes
Jan 8, 2018
masayag
force-pushed
the
virtualization_manager
branch
from
79333dd
to
0a4af20
Compare
masayag
commented
Jan 11, 2018
| @@ -23,6 +23,13 @@ class ManageIQ::Providers::Kubevirt::InfraManager < ManageIQ::Providers::InfraMa | |||
| require_nested :Template | |||
| require_nested :Vm | |||
|
|
|||
| include ManageIQ::Providers::Kubernetes::VirtualizationManagerMixin | |||
There was a problem hiding this comment.
this one adds dependency on the manageiq-providers-kubernetes project, therefore we add an explicit dependency on it
masayag
force-pushed
the
virtualization_manager
branch
from
0a4af20
to
461e9e6
Compare
The KubeVirt provider will be managed as a secondary provider of OpenShift/Kubernetes providers. The endpoint and authentication of kubevirt will reside under the container providers, selected by the :kubevirt role and authkey. Adding and removal of KubeVirt should be performed from the container manager virtualization tab.
masayag
force-pushed
the
virtualization_manager
branch
from
461e9e6
to
bd4be1a
Compare
|
@masayag Please do not merge your own PRs...that is a general ManageIQ policy...someone else should review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KubeVirt provider will be managed as a secondary provider of
OpenShift/Kubernetes providers.
The endpoint and authentication of kubevirt will reside under the
container providers, selected by the :kubevirt role and authkey.
Adding and removal of KubeVirt should be performed from the container
manager virtualization tab.
Depends on ManageIQ/manageiq-providers-kubernetes#197